Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: python3-pillow-heif #1396

Closed

Conversation

runlevel5
Copy link
Contributor

Motivation

This package is widely used in many Python-based projects and few friends have requested me to package it for them.

Notes

I've successfully got it built with koji but unsure how it would be with anda system. Please kindly provide me guidance if it does not get built successfully

@runlevel5 runlevel5 force-pushed the add-python3-pillow-heif branch 2 times, most recently from 55b1452 to f329667 Compare June 27, 2024 04:25
@madonuko
Copy link
Member

I think you need python3-rpm-macros as a BuildDependency

@runlevel5
Copy link
Contributor Author

I think you need python3-rpm-macros as a BuildDependency

I've just made another commit. Could you please trigger a new build for me? if it works, I will merge 2 commits into 1 and force push

@runlevel5
Copy link
Contributor Author

@madonuko to save you time from helping, could you please point me to a doc where I could actually run anda locally to make sure everything works?

@madonuko
Copy link
Member

madonuko commented Jun 27, 2024

If you have Terra installed, you could install anda via dnf.

https://developer.fyralabs.com/andaman/installation

You will also need to install terra-mock-configs

To manually run anda:

anda build anda/langs/python/python-heif/pkg -c terra-40-x86_64

Make sure your user is in the mock group. (sudo usermod -a -G mock username)

@runlevel5 runlevel5 force-pushed the add-python3-pillow-heif branch 2 times, most recently from 7090840 to e0f9a6d Compare June 29, 2024 11:41
@runlevel5
Copy link
Contributor Author

@madonuko it can be built successfully with anda locally. Please help me trigger the CI build

@madonuko madonuko enabled auto-merge (squash) June 29, 2024 12:49
auto-merge was automatically disabled July 1, 2024 00:44

Head branch was pushed to by a user without write access

@runlevel5 runlevel5 force-pushed the add-python3-pillow-heif branch from e0f9a6d to bebd70a Compare July 1, 2024 00:44
@runlevel5
Copy link
Contributor Author

@madonuko so the issue of the build is related to Python 3.13 (which would be defaulted to on F41). I think for the time-being the package could be built against f40 and f39 only. Possible?

Lastly, how to target f41 build with anda on local machine? Many thanks

@madonuko
Copy link
Member

madonuko commented Jul 1, 2024

I think for the time-being the package could be built against f40 and f39 only. Possible?

Yes, you can just make a new PR to terrapkg:f40 instead.

so the issue of the build is related to Python 3.13

I'm not so sure if that's actually true…? I'd try generating this from pyp2rpm instead to be honest.

how to target f41 build with anda on local machine?

We don't have mock files for f41 yet because it doesn't exist yet; Fedora 41 branches off from rawhide in August. You could target rawhide, you just need a container unfortunately.

@runlevel5 runlevel5 changed the base branch from frawhide to f40 July 2, 2024 00:15
@runlevel5 runlevel5 changed the base branch from f40 to frawhide July 2, 2024 00:16
@runlevel5
Copy link
Contributor Author

@madonuko let's have it for f40 for the time-being, I will inform the author to look into address the issue upstream and hopefully 0.17.0 would be out around the same time of f41

@runlevel5
Copy link
Contributor Author

Once the python 3.13 compatibility is addressed upstream, I will make a new PR

@runlevel5 runlevel5 closed this Jul 2, 2024
@runlevel5 runlevel5 deleted the add-python3-pillow-heif branch July 2, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants